Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Type to Curb Events #158

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jiffyclub
Copy link
Contributor

Explain pull request

Cities are often interested in how their curb users are paying for their time at the curb, for example the breakdown between cash, cards, mobile, etc. This adds a payment_type field to the Curb Event model and includes a list of potential payment types.

Closes #157.

Is this a breaking change

  • No, not breaking

Impacted Spec

Which API(s) will this pull request impact?

  • Events

Additional context

I totally just made up many of the items in the suggested list of payment types, input from practitioners on changes or additions is welcome.

Cities are often interested in how their curb users are paying for their
time at the curb, for example the breakdown between cash, cards, mobile, etc.
This adds a payment_type field to the Curb Event model and includes a list
of potential payment types.

Closes openmobilityfoundation#157.
@jiffyclub jiffyclub requested a review from a team as a code owner November 22, 2024 21:02
@schnuerle schnuerle added this to the 1.1 milestone Nov 26, 2024
@schnuerle schnuerle linked an issue Nov 26, 2024 that may be closed by this pull request
| `cash` | Bills or coins at a meter. |
| `credit_card` | Visa, Mastercard, etc at a meter. |
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. |
| `mobile` | Paid via a mobile app. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add QR code or app clip type payment where it's on mobile but not an app.

| ----------------- | ------------------------------------------------------ |
| `cash` | Bills or coins at a meter. |
| `credit_card` | Visa, Mastercard, etc at a meter. |
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be smart card or other type of card.

| Name | Description |
| ----------------- | ------------------------------------------------------ |
| `cash` | Bills or coins at a meter. |
| `credit_card` | Visa, Mastercard, etc at a meter. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea to add sub payment type as an option under payment_type. Visa, MC, apple pay, etc. Or V2X payment possible.

| `sms` | Paid via text message. |
| `billing` | Curb user will be billed for usage at a later time. |
| `permit` | Curb user has a permit allowing them to use the curb without payment. |
| `courtesy` | At a curb that normally requires payment this event for some reason did not. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| ----------------- | ------------------------------------------------------ |
| `cash` | Bills or coins at a meter. |
| `credit_card` | Visa, Mastercard, etc at a meter. |
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo: loyalty

| `cash` | Bills or coins at a meter. |
| `credit_card` | Visa, Mastercard, etc at a meter. |
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. |
| `mobile` | Paid via a mobile app. |
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile could potentially be ambiguous, since payment with a mobile app could be done with credit/debit cards, but also with digital wallets, prepaid accounts, permits, etc.

@hdmm3
Copy link

hdmm3 commented Dec 10, 2024

I wonder if it's worth distinguishing between the payment channel and the payment method.
The payment channel is the medium or platform used to pay: meter, mobile app, website, sms. The payment method would be the instrument used to pay: cash, credit/debit card, transit card, prepaid account, permit, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a payment method field to CDS Events
3 participants