-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Payment Type to Curb Events #158
base: dev
Are you sure you want to change the base?
Add Payment Type to Curb Events #158
Conversation
Cities are often interested in how their curb users are paying for their time at the curb, for example the breakdown between cash, cards, mobile, etc. This adds a payment_type field to the Curb Event model and includes a list of potential payment types. Closes openmobilityfoundation#157.
| `cash` | Bills or coins at a meter. | | ||
| `credit_card` | Visa, Mastercard, etc at a meter. | | ||
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. | | ||
| `mobile` | Paid via a mobile app. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add QR code or app clip type payment where it's on mobile but not an app.
| ----------------- | ------------------------------------------------------ | | ||
| `cash` | Bills or coins at a meter. | | ||
| `credit_card` | Visa, Mastercard, etc at a meter. | | ||
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also be smart card or other type of card.
| Name | Description | | ||
| ----------------- | ------------------------------------------------------ | | ||
| `cash` | Bills or coins at a meter. | | ||
| `credit_card` | Visa, Mastercard, etc at a meter. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea to add sub payment type as an option under payment_type
. Visa, MC, apple pay, etc. Or V2X payment possible.
| `sms` | Paid via text message. | | ||
| `billing` | Curb user will be billed for usage at a later time. | | ||
| `permit` | Curb user has a permit allowing them to use the curb without payment. | | ||
| `courtesy` | At a curb that normally requires payment this event for some reason did not. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
voucher
and test
might also be useful options from MDS.
https://github.com/openmobilityfoundation/mobility-data-specification/blob/main/modes/passenger-services.md#fare-attributes
| ----------------- | ------------------------------------------------------ | | ||
| `cash` | Bills or coins at a meter. | | ||
| `credit_card` | Visa, Mastercard, etc at a meter. | | ||
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: loyalty
| `cash` | Bills or coins at a meter. | | ||
| `credit_card` | Visa, Mastercard, etc at a meter. | | ||
| `membership_card` | A card used at a meter to pay via a corporate membership or loyalta program, etc. | | ||
| `mobile` | Paid via a mobile app. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mobile
could potentially be ambiguous, since payment with a mobile app could be done with credit/debit cards, but also with digital wallets, prepaid accounts, permits, etc.
I wonder if it's worth distinguishing between the payment channel and the payment method. |
Explain pull request
Cities are often interested in how their curb users are paying for their time at the curb, for example the breakdown between cash, cards, mobile, etc. This adds a
payment_type
field to the Curb Event model and includes a list of potential payment types.Closes #157.
Is this a breaking change
Impacted Spec
Which API(s) will this pull request impact?
Events
Additional context
I totally just made up many of the items in the suggested list of payment types, input from practitioners on changes or additions is welcome.