(chore) Various tooling tweaks #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes the following changes to the tooling used in this project: - Update ESLint config with `import` and `react-hooks` plugins - Add turborepo for build caching and script parallelization - Align TypeScript and Jest configs with OpenMRS standards - Separate linting from formatting scripts so they can be run separately as described in [similar PRs](openmrs/openmrs-esm-patient-chart#1774) for other OpenMRS frontend modules - Update Yarn to latest stable version - Remove redundant Webpack `scriptRuleConfig` override This aligns our tooling configuration with other OpenMRS frontend modules, improving consistency across the ecosystem.
denniskigen
force-pushed
the
chore/tooling-tweaks
branch
from
88a4db4 to
541a0fd
Compare
| }, | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended" |
There was a problem hiding this comment.
Same concern here about the testing eslint plugins
NethmiRodrigo
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Thanks @denniskigen! LGTM! Same few concerns that I had in the other PR
src/components/saved-cohorts/saved-cohorts-options/saved-cohort-options.test.tsx
Show resolved
Hide resolved
src/components/search-by-drug-orders/search-by-drug-orders.component.tsx
Outdated
Show resolved
Hide resolved
src/components/search-by-drug-orders/search-by-drug-orders.resources.ts
Outdated
Show resolved
Hide resolved
src/components/search-by-encounters/search-by-encounters.component.tsx
Outdated
Show resolved
Hide resolved
src/components/search-by-encounters/search-by-encounters.resources.ts
Outdated
Show resolved
Hide resolved
src/components/search-history/search-history-options/search-history-options.component.tsx
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following changes to the tooling used in this project:
importandreact-hookspluginsscriptRuleConfigoverrideThis aligns our tooling configuration with other OpenMRS frontend modules, improving consistency across the ecosystem.