Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) login: Restore footer styles for additional logos #1245

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

suubi-joshua
Copy link
Contributor

@suubi-joshua suubi-joshua commented Dec 17, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. Ensure your PR title includes a conventional commit label (such as feat, fix, or chore, among others). See existing PR titles for inspiration.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Transferred the left behind css for the footer component that deals with the additional logos.

Screenshots

image

Related Issue

https://openmrs.atlassian.net/browse/O3-4100

Other

@suubi-joshua
Copy link
Contributor Author

@denniskigen FYI

@@ -13,6 +13,57 @@
width: 100%;
}

.logosContainer {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suubi-joshua I've taken the liberty of pushing a commit that removes the margin-top: 6.75rem style property from the footer class. That style have any effect since the element is absolutely positioned. Other changes include switching to Carbon layout tokens instead of using rem values.

opacity: 80%;
}

@media only screen and (max-width: 1024px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've also removed the login-card class from this block as it doesn't seem to be used anywhere in the footer component.

@denniskigen
Copy link
Member

denniskigen commented Dec 17, 2024

Could you retest to make sure things are working ok fairly soon @suubi-joshua? I'd like to include this fix in the release.

@denniskigen denniskigen changed the title (fix) Refactor css for footer. (fix) login: Restore footer styles for additional logos Dec 17, 2024
@denniskigen
Copy link
Member

denniskigen commented Dec 17, 2024

Merging as we need to get going on the releases front. Thanks, @suubi-joshua.

@denniskigen denniskigen merged commit bdb5a06 into openmrs:main Dec 17, 2024
14 checks passed
@suubi-joshua
Copy link
Contributor Author

Merging as we need to get going on the releases front. Thanks, @suubi-joshua.

Sorry was on a call, just seeing this now but all LGTM. Thanks @denniskigen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants