-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) login: Restore footer styles for additional logos #1245
Conversation
@denniskigen FYI |
@@ -13,6 +13,57 @@ | |||
width: 100%; | |||
} | |||
|
|||
.logosContainer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suubi-joshua I've taken the liberty of pushing a commit that removes the margin-top: 6.75rem
style property from the footer
class. That style have any effect since the element is absolutely positioned. Other changes include switching to Carbon layout tokens instead of using rem values.
opacity: 80%; | ||
} | ||
|
||
@media only screen and (max-width: 1024px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've also removed the login-card
class from this block as it doesn't seem to be used anywhere in the footer component.
Could you retest to make sure things are working ok fairly soon @suubi-joshua? I'd like to include this fix in the release. |
Merging as we need to get going on the releases front. Thanks, @suubi-joshua. |
Sorry was on a call, just seeing this now but all LGTM. Thanks @denniskigen |
Requirements
feat
,fix
, orchore
, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
Transferred the left behind css for the footer component that deals with the additional logos.
Screenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-4100
Other