(feat) Allow registering workspace groups via routes.json #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Size Change: -137 kB (-2.17%) Total Size: 6.19 MB
ℹ️ View Unchanged
|
Merged
3 tasks
vasharma05
requested review from
ibacher,
denniskigen,
brandones and
chibongho
and removed request for
ibacher,
denniskigen and
brandones
vasharma05
force-pushed
the
feat/workspace-group-registration
branch
from
569801e to
378e4f6
Compare
ibacher
reviewed
Jan 8, 2025
| @@ -28,6 +29,14 @@ const workspaceRegistrationStore = createGlobalStore<WorkspaceRegistrationStore> | |||
| workspaces: {}, | |||
| }); | |||
|
|
|||
| interface WorkspaceGroupRegistrationStore { | |||
| workspaceGroups: Record<string, { name: string; members: Array<string> }>; | |||
There was a problem hiding this comment.
Why do we have both a key and a name property?
There was a problem hiding this comment.
Yes, the key and the name will be the same, but name is kept to get the whole workspace group definition whenever intended, instead of defining the name as the key again.
|
Hi @ibacher, |
Twiineenock
pushed a commit
to Twiineenock/openmrs-esm-core
that referenced
this pull request
Jan 14, 2025
* Registering workspace groups similar to registration of individual workspaces * Update docs * Update tests * Using the workspace name instead of workspace group name * Allow workspace to define groups it can be a part of * Review changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
feat,fix, orchore, among others). See existing PR titles for inspiration.For changes to apps
If applicable
Summary
This PR allows workspace groups to be registered via routes.json, which is similar to how workspaces are registered. In the previous implementation of
launchWorkspaceGroupin #1185, there was a design flaw, wherein, for a workspace to be part of a workspace group, it should define the respective group under its definition in theroutes.json. Now, the workspace group registration will define the individual workspaces that will be themembersof the respective workspace group, hence the individual workspace will not need to know what all workspace groups it is a part of.Screenshots
Yet to test out changes, since dev3 is down.
Related Issue
https://issues.openmrs.org/browse/O3-4077
Other