-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore) Take advantage of Yarn's workspace versioning capabilities #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: -2.58 MB (-48%) 🎉 Total Size: 2.83 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
For changes to apps
If applicable
Summary
Everything except apps now explicitly use
workspace:*
versions when referring to the framework, shell, or tooling. As a result of this change, I have also removed Lerna, as it does not understand these versions, and replaced it with equivalent Yarn commands.NOTE: This currently builds on #800 which upgrades the version of Yarn.
Screenshots
Related Issue
Other
The main idea here was to fix hacks we had in a couple of core scripts that just try to keep specific versions in sync (so, e.g., the openmrs CLI always points to a fixed version of the app-shell, the app-shell always points to a fixed version of the framework, etc). Yarn provides a handy-dandy tool to do this automatically by specifying a version like
workspace:*
.Once those were specified, it turns out Lerna doesn't actually understand those commands, so I removed our last vestigal uses of Lerna, replacing it with a combination of Turbo and pure Yarn.