(feat) Patient name sorting #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Thanks for working on this, @icrc-psousa, I've left some suggestions.
src/group-form-entry-workflow/attendance-table/AttendanceTable.tsx
Outdated
Show resolved
Hide resolved
Thanks for your input @denniskigen , I've made the suggested changes. I've also fixed the sorting on the modal not to consider the patient id so that the patient list order is always the same. |
ibacher
approved these changes
Mar 27, 2024
Comment on lines
64
to
66
| const getPatients = async (uuids) => { | ||
| return await Promise.all(uuids.map((uuid) => fetchCurrentPatient(uuid))); | ||
| }; |
There was a problem hiding this comment.
Note that the async and await here are superfluous.
icrc-jofrancisco
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
When creating a group, no specific order for the patients is explicitly defined. Initially, the order established during the creation is maintained for the first session. However, for subsequent sessions, the order of patients changes, following the sequence in which they are retrieved from the database.
With this development the order of the patients within a group will always be alphabetical.
Screenshots