(chore) Configure prettier #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
chore/prettier
branch
from
cd1e197 to
e388d80
Compare
vasharma05
force-pushed
the
chore/prettier
branch
from
e388d80 to
6231bf6
Compare
vasharma05
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Although Prettier is set up in this project, we don't have a corresponding Prettier config file. In this PR, I've added a config file with the configuration options we use across our key repositories.
I've also removed the following plugins from ESLint :
ts-react-important-stuff- which is quite dated at this point, and can be swapped out with a combination of ESLint's and @typescript-eslint/eslint-plugin's recommended configs. I intend to introduce these in a subsequent PR.plugin:prettier/recommended- because we don't want to mix formatting and linting concerns. I have a subsequent PR on the way that will further decouple ESLint and Prettier.Screenshots
Related Issue
Other