Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Allowing confirmation modal to close form / preventing pop up in view mode #136

Merged
merged 1 commit into from
Nov 3, 2023
Merged

(fix) Allowing confirmation modal to close form / preventing pop up in view mode #136

merged 1 commit into from
Nov 3, 2023

Conversation

arodidev
Copy link
Contributor

@arodidev arodidev commented Nov 2, 2023 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

  • This PR fixes the issue with the confirmation modal not closing the form upon clicking the "confirm" button.

  • This also fixes a follow up issue where the pop-up modal was showing even on view mode.

Screenshots

Screen.Recording.2023-11-02.at.13.04.41.mov

Related Issue

Other

@pirupius pirupius merged commit 6d7981b into openmrs:main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arodidev @pirupius