Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Remove deleted field from the form context #428

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes an issue where deleted form fields (deleted cloned fields) re-appear on form submission. The issue is fixed by removing the deleted field(s) from the form context.

Screenshots

Issue:

Screencast.from.20-11-24.16_54_58.webm

Related Issue

Other

@samuelmale samuelmale requested a review from pirupius November 21, 2024 15:47
Copy link

Size Change: +24 B (0%)

Total Size: 1.23 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 379 kB 0 B
dist/225.js 2.57 kB 0 B
dist/254.js 88.7 kB 0 B
dist/277.js 1.85 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/343.js 253 kB +16 B (+0.01%)
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/635.js 14.4 kB 0 B
dist/690.js 11.5 kB 0 B
dist/697.js 111 kB 0 B
dist/70.js 483 B 0 B
dist/979.js 6.87 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 344 kB +8 B (0%)
dist/openmrs-esm-form-engine-lib.js 3.8 kB 0 B

compressed-size-action

Copy link
Member

@usamaidrsk usamaidrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samuelmale samuelmale merged commit f5fe919 into main Nov 21, 2024
4 checks passed
@samuelmale samuelmale deleted the fix/removeDeletedFieldFromContext branch November 21, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants