-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3682 - Refactor File Picker Component and Fix Multiple Selection Support #431
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR @suubi-joshua! Just a couple of concerns:
|
@samuelmale I made some changes and added that video. Remaining with unit test. |
@samuelmale should the uploads from the file components show up in the attachments preview section? |
@suubi-joshua By attachments preview section do you mean the "Attachments dashboard" on the patient chart? If so, yes! and I believe that's already working. If you meant a backed-in preview (within the form) on file selection; Yes! Right now, there is no preview of the uploaded file. In a context where we have multiple selections, we can't preview all the selected files at once; we could do something like: Alternatively, we could seek UX advisory Generally, we need to refine the UX of our file picker for more practicality. |
@samuelmale thanks for that clarification, I needed clarification on both previews. |
@samuelmale happy new year this brings a new thought in my mind. Can we consider refactoring this to have it function the way the visit-note form works Screencast.from.09-01-25.15.41.38.webm |
I like the idea and agree we need to refactor and refine the entire UX; can you seek UX advisory? |
Feedback provided in slack: https://openmrs.slack.com/archives/CKS32D55G/p1736830786512069?thread_ts=1736795272.053099&cid=CKS32D55G |
Requirements
Summary
This PR refactors the file picker component in the form engine to align with standard input design and improve functionality. The
handleFilePickerChange
function now supports multiple file selections, allowing users to upload multiple files by appending them to the existing value using thefield.questionOptions.allowMultiple
configuration. The component also displays previews for all selected files, integrates camera capture functionality with live preview and upload options, and addresses previous limitations in file selection and usability, ensuring a consistent and enhanced user experience.Screenshots
Screencast.from.27-11-24.18.06.45.webm
Related Issue
https://openmrs.atlassian.net/browse/O3-3682
Other