Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Bump @carbon/react to v1.71.0 #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+227 −32
Open

(chore) Bump @carbon/react to v1.71.0 #435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"access": "public"
},
"dependencies": {
"@carbon/react": ">1.47.0 <1.50.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @elishabantana there's an ongoing discussion to make this a peer dependency all together. The reason it was previously like this was because of Carbon's searchable multi-select behavior between versions.
We also wouldn't want to give a static version because this is package is only a library and not a microfrontend

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pirupius sorry I'm a bit lost. Does that mean we shouldn't update carbon or we should update it to be a more up-to-date range?

Copy link
Member

@pirupius pirupius Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NethmiRodrigo The reason this was added was to resolve a breaking change in some components. The resolution would involve

  1. Testing and fixing any breaking changes in some components with newer versions Carbon
  2. Move carbon back to being a peer dependency.

"@carbon/react": "1.71.0",
"classnames": "^2.5.1",
"lodash-es": "^4.17.21",
"react-error-boundary": "^4.0.13",
Expand Down
Loading
Loading