(feat) O3-4201: Enhance Number Question Labels Display Unit and Range (Min/Max) from Concept #454
Conversation
…(min-max) to label and min/max to form
|
@samuelmale @ibacher please let me know if you had other approaches in mind for this or issues
|
src/hooks/useFormFieldsMeta.ts
Outdated
| { | ||
| if(matchingConcept.units) | ||
| { | ||
| field.label = field.label + " (" + matchingConcept.units + ")"; |
There was a problem hiding this comment.
This potentially breaks i18n workflows because it mutates the field's label which is implicitly used as the translation key. Since the concept is stored under the field's meta, this can safely be done within the number component post label translation; something like:
<NumberInput
id={field.id}
label={<FieldLabel field={field} customLabel={t(field.label) + extractFieldUnitsAndRange(field.meta.concept)} />}There was a problem hiding this comment.
@samuelmale thanks, moved the units and range to the number component. Also for a concept that defines min but not max it looks like
leaving critical alone for now
There was a problem hiding this comment.
We should harmonize the view here to what we're doing here, which is >= 0 or <= 100 things like that. (Note that "Min" is hard to support because now that's a string that needs to be translated).
There was a problem hiding this comment.
unfortunately it splits the label onto a new line, but the format should match the chart lab result format
There was a problem hiding this comment.
I mean, that was always going to be a possibility... This just made it apparent for that one case.
| @@ -5,7 +5,7 @@ import { type FetchResponse, type OpenmrsResource, openmrsFetch, restBaseUrl } f | |||
| type ConceptFetchResponse = FetchResponse<{ results: Array<OpenmrsResource> }>; | |||
|
|
|||
| const conceptRepresentation = | |||
| 'custom:(uuid,display,conceptClass:(uuid,display),answers:(uuid,display),conceptMappings:(conceptReferenceTerm:(conceptSource:(name),code)))'; | |||
| 'custom:(units,lowAbsolute,hiAbsolute,uuid,display,conceptClass:(uuid,display),answers:(uuid,display),conceptMappings:(conceptReferenceTerm:(conceptSource:(name),code)))'; | |||
There was a problem hiding this comment.
@ibacher when is it necessary to use hiCritical vs lowCritical?
There was a problem hiding this comment.
All of the values that aren't lowAbsolute and hiAbsolute are basically only for displaying concerning results (outside the normal range, but inside the critical range) or critical results (outside the critical range, but within the absolute range). Does that make sense? lowAbsolute and hiAbsolute should be rare and only in cases where the value can never exceed that range (e.g., SpO2 is a percent, so it's always between 0 and 100; heights and weights should never be a negative number, things like that).
There was a problem hiding this comment.
But we can handle critical icons in a separate PR.
…l, add test concept with units and range
Add (unit) (min-max) to label, validate input against concept min/max
https://openmrs.atlassian.net/browse/O3-4201
Related: https://openmrs.atlassian.net/browse/O3-4122
4122 also suggests a warning for values within the absolute range but outside normal or critical range. Looking for suggestions on how to implement that, and how to add a test case for a concept with units and min/max
Requirements
Summary
Screenshots
Related Issue
Other