Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O3-3540: Bump @carbon/react to v1.73.0 #456

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dilankavishka
Copy link

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Upgrade to @carbon/react 1.73.0

Screenshots

Related Issue

https://openmrs.atlassian.net/jira/software/c/projects/O3/issues/O3-3540?jql=project%20%3D%20%22O3%22%20AND%20assignee%20%3D%20empty%20ORDER%20BY%20created%20DESC

Other

@dilankavishka
Copy link
Author

@brandones Could you please review this?

@samuelmale
Copy link
Member

@dilankavishka can we have Carbon as a peer dependency instead?

@dilankavishka
Copy link
Author

@samuelmale do you mean like, add both devDependencies and peerDependencies like other apps?

@samuelmale
Copy link
Member

@dilankavishka yes! Just like @openmrs/esm-framework.

@dilankavishka
Copy link
Author

@samuelmale Sure! I will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants