(fix) Fix misplaced metrics extension slot #191
Conversation
|
Could you attach a screenshot that confirms that this works as you expect? |
| import { ExtensionSlot } from '@openmrs/esm-framework'; | ||
| import React from 'react'; | ||
|
|
||
| const PageMetrics: React.FC = () => { |
There was a problem hiding this comment.
Nit: I'd just call this Metrics for consistency with the file name.
denniskigen
changed the title
packages/esm-home-app/src/index.ts
Outdated
| @@ -24,6 +24,8 @@ export const homeWidgetDbLink = getSyncLifecycle(createDashboardLink(dashboardMe | |||
|
|
|||
| export const homeWidgetDashboard = getSyncLifecycle(homeWidgetDashboardComponent, options); | |||
|
|
|||
| export const metricsSlot = getAsyncLifecycle(() => import('./metrics/metrics.component'), options); | |||
There was a problem hiding this comment.
This can be named better @denniskigen should we just call this metrics,metricsContainer or MetricsComponent
| export const metricsSlot = getAsyncLifecycle(() => import('./metrics/metrics.component'), options); | |
| export const metricsContainer = getSyncLifecycle(MetricsComponent, options); |
| import { ExtensionSlot } from '@openmrs/esm-framework'; | ||
| import React from 'react'; | ||
|
|
||
| const PageMetrics: React.FC = () => { |
There was a problem hiding this comment.
The naming in the index should trickle down here
| @@ -24,6 +24,8 @@ export const homeWidgetDbLink = getSyncLifecycle(createDashboardLink(dashboardMe | |||
|
|
|||
| export const homeWidgetDashboard = getSyncLifecycle(homeWidgetDashboardComponent, options); | |||
|
|
|||
| export const metrics = getAsyncLifecycle(() => import('./metrics/metrics.component'), options); | |||
There was a problem hiding this comment.
| export const metrics = getAsyncLifecycle(() => import('./metrics/metrics.component'), options); | |
| export const metrics = getSyncLifecycle(Metrics, options); |
There was a problem hiding this comment.
Add the import Metrics from ./metrics/metrics.component at the top of the file
There was a problem hiding this comment.
Isn't getAsyncLifecycle better for app performance? Or does it have specific use cases? Reference.
There was a problem hiding this comment.
I think there's a bit of misalignment on when to use getAsyncLifecycle and when to use getSyncLifecycle
homeWidgetDashboard uses getSyncLifecycle to load a component that is similar to metrics. Let's leave as is for now and will circle back.
Requirements
Summary
This PR is a follow up fix to an error introduces by this PR.
Screenshots
None.
Related Issue
None.
Other
None.