(chore) Add form engine lib translations #2200
Open
+231
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirupius
force-pushed
the
chore/add-form-engine-lib-translations
branch
from
816a907 to
9e3eb30
Compare
|
Size Change: +2.69 kB (+0.02%) Total Size: 16.1 MB ℹ️ View Unchanged
|
3 tasks
|
This PR is dependent on openmrs/openmrs-esm-form-engine-lib#457 that needs to be merged in first and a bump of the lib made. |
3 tasks
denniskigen
reviewed
Jan 17, 2025
There was a problem hiding this comment.
Thanks for this, @pirupius. I think Transifex should be the source of truth for non-en locale keys and strings. I don't expect to see them included in the final diff.
There was a problem hiding this comment.
Makes sense. Let me revert changes to the rest of the files and leave only the en.
There was a problem hiding this comment.
Let's not remove the current translations, as it will impact the implementations using these translations.
We can put these translations for review on transifex, as we are close to a new release candidate.
There was a problem hiding this comment.
That's a valid point because there already implementations using them us inclusive and we're in production. @denniskigen are you comfortable with that?
pirupius
force-pushed
the
chore/add-form-engine-lib-translations
branch
from
d94264d to
9e3eb30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Adds form-engine-lib translations and updates index.ts to make them available
Screenshots
Related Issue
Other