(fix) O3-4358: Remove bed description and fix location change bug #1447
+90
−93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NethmiRodrigo
commented
Jan 17, 2025
packages/esm-bed-management-app/src/bed-administration/bed-administration-form.component.tsx
Outdated
Show resolved
Hide resolved
NethmiRodrigo
commented
Jan 17, 2025
Comment on lines
-106
to
-109
| export interface BedFormData extends BedWithLocation { | ||
| description: string; | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed this type since description is not needed
|
Size Change: +202 B (0%) Total Size: 7.27 MB ℹ️ View Unchanged
|
NethmiRodrigo
commented
Jan 17, 2025
| setValue('location', { display: selectedLocation.display, uuid: selectedLocation.uuid }); | ||
| if (selectedLocation) | ||
| setValue('location', { display: selectedLocation.display, uuid: selectedLocation.uuid }); | ||
| else setValue('location', { display: '', uuid: '' }); |
There was a problem hiding this comment.
This is to account for when you press the x option on a selected location option to clear the selection. Previously, this would cause an error since selectedLocation would be null when you do so
NethmiRodrigo
requested review from
mseaton,
denniskigen,
ibacher and
chibongho
mseaton
approved these changes
Jan 17, 2025
NethmiRodrigo
force-pushed
the
fix/O3-4358
branch
from
f523a4d to
1241ffa
Compare
NethmiRodrigo
force-pushed
the
fix/O3-4358
branch
from
1241ffa to
0886e2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR adds translation support to some strings, fixes a bug that occurred when clearing a selected location in the bed creation form, removes the bed description since its not supported by the backend and updates the column header in ward summary component.
Screenshots
Column header now says
Typeinstead ofName, since the value shown is the bed type. Also the columndescriptionis removedThe
descriptionfield is removed from the bed form.Related Issue
https://issues.openmrs.org/browse/O3-4358
https://issues.openmrs.org/browse/O3-4359
Other