Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) Better handling of diagnoses #103

Merged
merged 2 commits into from
Nov 21, 2023
Merged

(fix) Better handling of diagnoses #103

merged 2 commits into from
Nov 21, 2023

Conversation

icrc-psousa
Copy link
Contributor

@icrc-psousa icrc-psousa commented Nov 17, 2023 •
edited
Loading

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

Reviewed encounter payload regarding diagnosis:

  • Don't send diagnosis within encounter payload in case no diagnosis were changed
  • Resolved the issue with the payload when deleting a diagnosis
  • Ensured proper handling of newly added and modified diagnoses while constructing the encounter payload
  • Reviewed unit tests to align with backend's expected diagnosis payload format

@icrc-psousa icrc-psousa marked this pull request as ready for review November 20, 2023 14:13
@icrc-psousa icrc-psousa requested a review from ibacher November 21, 2023 14:58
@ibacher ibacher changed the title (fix) Diagnoses handling (fix) Better handling of diagnoses Nov 21, 2023
@ibacher ibacher merged commit 271953e into main Nov 21, 2023
3 checks passed
@ibacher ibacher deleted the fix/diagnoses-handling branch November 21, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibacher ibacher ibacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icrc-psousa @ibacher