-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Improved field validation UX #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
force-pushed
the
feat/field-validation-ui-ux
branch
from
January 11, 2024 22:07
4a9f666
to
8d1e067
Compare
denniskigen
changed the title
(test) Add unit tests for NumberInputComponent (#117)
(feat) Improved field validation UX
Jan 11, 2024
denniskigen
commented
Jan 11, 2024
projects/ngx-formentry/src/components/ngx-remote-select/remote-select.component.html
Show resolved
Hide resolved
denniskigen
commented
Jan 11, 2024
projects/ngx-formentry/src/components/number-input/number-input.component.html
Show resolved
Hide resolved
denniskigen
commented
Jan 11, 2024
projects/ngx-formentry/src/form-entry/form-renderer/form-renderer.component.html
Show resolved
Hide resolved
denniskigen
commented
Jan 11, 2024
projects/ngx-formentry/src/form-entry/form-renderer/form-renderer.component.scss
Show resolved
Hide resolved
denniskigen
commented
Jan 11, 2024
@denniskigen LGTM |
donaldkibet
approved these changes
Jan 18, 2024
denniskigen
force-pushed
the
feat/field-validation-ui-ux
branch
from
January 18, 2024 16:28
8d1e067
to
bea0250
Compare
ibacher
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @denniskigen! This looks like a great improvement.
projects/ngx-formentry/src/components/ngx-remote-select/ngx-remote-select.component.ts
Outdated
Show resolved
Hide resolved
projects/ngx-formentry/src/form-entry/form-renderer/form-renderer.component.html
Outdated
Show resolved
Hide resolved
Thanks for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR improves the appearance and behavior of various fields when they fail validation. Specifically, fields with invalid values now have an error outline indicating that their content is invalid. Additionally, various validation error messages and their equivalent locale-specific translations have been amended to communicate their intent more effectively. In summary:
These improvements enhance the user experience by providing clear and specific feedback when fields fail validation, making it easier for users to understand and address validation issues.
Screenshots
field-validation-ui-ux-before.mp4
field-validation-ui-ux.mp4
Related Issue
None
Other
None