Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) Improved field validation UX #118

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Conversation

denniskigen
Copy link
Member

@denniskigen denniskigen commented Jan 11, 2024

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR improves the appearance and behavior of various fields when they fail validation. Specifically, fields with invalid values now have an error outline indicating that their content is invalid. Additionally, various validation error messages and their equivalent locale-specific translations have been amended to communicate their intent more effectively. In summary:

  • Fields with invalid values now have a visible error outline, indicating that their content is invalid.
  • I've updated validation error messages to improve their clarity and effectiveness.
  • I've updated locale-specific translations for validation error messages.

These improvements enhance the user experience by providing clear and specific feedback when fields fail validation, making it easier for users to understand and address validation issues.

Screenshots

Before (note the absence of styling around inputs that fail validation)

field-validation-ui-ux-before.mp4

After

field-validation-ui-ux.mp4

Related Issue

None

Other

None

@denniskigen denniskigen force-pushed the feat/field-validation-ui-ux branch from 4a9f666 to 8d1e067 Compare January 11, 2024 22:07
@denniskigen denniskigen changed the title (test) Add unit tests for NumberInputComponent (#117) (feat) Improved field validation UX Jan 11, 2024
src/translations/km.json Outdated Show resolved Hide resolved
@donaldkibet
Copy link
Member

@denniskigen LGTM

@denniskigen denniskigen force-pushed the feat/field-validation-ui-ux branch from 8d1e067 to bea0250 Compare January 18, 2024 16:28
Copy link
Member

@ibacher ibacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @denniskigen! This looks like a great improvement.

@denniskigen denniskigen merged commit f1f94da into main Jan 18, 2024
3 checks passed
@denniskigen denniskigen deleted the feat/field-validation-ui-ux branch January 18, 2024 22:34
@denniskigen
Copy link
Member Author

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants