(chore) Bump Angular to v18 #156
Conversation
donaldkibet
requested review from
denniskigen,
vasharma05 and
ibacher
and removed request for
denniskigen
denniskigen
changed the title
There was a problem hiding this comment.
Great to see this, @donaldkibet! I've left some suggestions for package version bumps.
| "@angular-extensions/elements": "^17.1.1", | ||
| "@angular/animations": "^17.3.12", | ||
| "@angular/animations": "^18.2.13", | ||
| "@angular/cdk": "^17.3.10", |
There was a problem hiding this comment.
Can we bump @angular/cdk and @angular-extensions/elements to the latest 18.2.x. releases as well?
| "@angular/forms": "^18.2.13", | ||
| "@angular/platform-browser": "^18.2.13", | ||
| "@angular/platform-browser-dynamic": "^18.2.13", | ||
| "@angular/router": "^18.2.13", | ||
| "@carbon/styles": "1.x", | ||
| "@ng-select/ng-select": "^12.0.7", |
There was a problem hiding this comment.
This should be v13.x.x per this version compatibility table.
| "@angular/forms": "^18.2.13", | ||
| "@angular/platform-browser": "^18.2.13", | ||
| "@angular/platform-browser-dynamic": "^18.2.13", | ||
| "@angular/router": "^18.2.13", | ||
| "@carbon/styles": "1.x", | ||
| "@ng-select/ng-select": "^12.0.7", | ||
| "@ngx-translate/core": "^15.0.0", |
There was a problem hiding this comment.
Not strictly necessary, but I think we can safely bump this to v16.x based on this version compatibility table.
| @@ -3,13 +3,13 @@ | |||
| "version": "17.0.0", | |||
| "dependencies": {}, | |||
| "peerDependencies": { | |||
| "@angular/animations": "^17.3.12", | |||
| "@angular/animations": "^18.2.13", | |||
| "@angular/cdk": "^17.3.10", | |||
There was a problem hiding this comment.
We should probably bump @angular/cdk to the latest v18.x.x release.
| "@ng-select/ng-select": "^12.0.7", | ||
| "@ngx-translate/core": "^15.0.0", |
|
This upgrade will necessitate a corresponding version upgrade for the Angular file uploader, a direct dependency of this library, as well as a Node version bump (to
|
|
@donaldkibet I've just released v18 of ngx-file-uploader with Angular 18 support https://github.com/openmrs/openmrs-ngx-file-uploader/releases/tag/v18.0.0. All you'd need to do is bump the dependency to the latest available version: |
Well, we're going to need to upgrade anyway. Support for 18 drops in May. |
Requirements
Summary
Bump to version 18
Screenshots
Related Issue
Other