SDK-343 - Setup task presents both the release and latest snapshot of… #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the same version as options
mseaton
commented
Nov 26, 2024
| List<String> res = helper.getSuggestedVersions( | ||
| createTestVersions("1.8.8", "1.8.3", "1.8.10-SNAPSHOT", "1.8.9-alpha"), 1); | ||
| assertThat(res, hasItem("1.8.9-alpha")); | ||
| assertThat(res, hasItem("1.8.10-SNAPSHOT")); |
There was a problem hiding this comment.
This seems like a bug in the test, which allowed bugs in the code to pass. If asking for suggested versions with a max number of 1, it should return the latest suggested version, and 1.8.10 > 1.8.9
| createTestVersions("1.1.2", "1.5.6", "1.5.7-SNAPSHOT" , "1.1.2-alpha", "1.1.0-SNAPSHOT", "1.3.0-SNAPSHOT", "1.3.0", "1.1.0"), 6); | ||
| assertThat(res, contains("1.5.7-SNAPSHOT", "1.5.6", "1.3.0", "1.3.0-SNAPSHOT", "1.1.2")); | ||
| createTestVersions("1.1.2", "1.5.6", "1.5.7-SNAPSHOT", "1.1.2-alpha", "1.1.0-SNAPSHOT", "1.3.0-SNAPSHOT", "1.3.0", "1.1.0"), 6); | ||
| assertThat(res, contains("1.5.7-SNAPSHOT", "1.5.6", "1.3.0", "1.1.2")); |
There was a problem hiding this comment.
Ultimately, this bug in this test was actually the case this ticket was aiming to fix. The suggested versions should not include both a release and a snapshot with the same incremental version. After fixing the code, this test broke, then I fixed the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the same version as options
see https://openmrs.atlassian.net/browse/SDK-343