SDK-368: SDK should prompt for the database logins again if invalid logins were entered

[mherman22]

Description of what I changed

Issue I worked on

see https://openmrs.atlassian.net/browse/SDK-368

Screenshot(s)

Checklist: I completed these to help reviewers :)

• My IDE is configured to follow the code style of this project.

  No? Unsure? -> configure your IDE, format the code and add the changes with git add . && git commit --amend

• I have added tests to cover my changes. (If you refactored
  existing code that was well tested you do not have to add tests)

  No? -> write tests and add them to this commit git add . && git commit --amend

• I ran mvn clean install right before creating this pull request and
  added all formatting changes to my commit.

  No? -> execute the above command

• All new and existing tests passed.

  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.

• My pull request is based on the latest changes of the master branch.

  No? Unsure? -> execute command git pull --rebase upstream master

[mseaton]

This all looks like a nice improvement to me. I do think it would be ideal if we could keep all of the prompting in the wizard itself, and of course the URL could also be wrong, not just the username and password, so giving a chance to fix that might also be worthwhile (eg. maybe the wrong database name was used, or maybe the wrong database option was chosen). I'm happy enough to see this get committed as is, and leave that for another day if needed though.

[wikumChamith]

@mherman22 I see the error message even the first time SDK prompts for credentials. Can we avoid that?

Database connection failed (attempt 1 of 3): Invalid database credentials. Please check your username and password.

[wikumChamith]

We should also implement this to when we are connecting to an existing docker container:

openmrs-sdk/sdk-commons/src/main/java/org/openmrs/maven/plugins/utility/DefaultWizard.java

Lines 903 to 930 in 0280368

	public void promptForDockerizedDb(Server server, DockerHelper dockerHelper, String dockerHost)
	throws MojoExecutionException {
	promptForDockerHostIfMissing(dockerHelper, dockerHost);
	String containerId = prompt(
	"Please specify your container id/name/label (you can get it using command `docker ps -a`)");
	String username = prompt("Please specify DB username");
	String password = promptForPassword("Please specify DB password");
	String defaultDbUri = getDefaultDbUri(server, dockerHelper);
	String dbUri = promptForValueIfMissingWithDefault(
	"Please specify database uri (-D%s)", server.getDbUri(), "dbUri", defaultDbUri);
	if (dbUri.startsWith("jdbc:mysql:")) {
	server.setDbDriver(SDKConstants.DRIVER_MYSQL_OLD);
	dbUri = addMySQLParamsIfMissing(dbUri);
	}
	dbUri = dbUri.replace(DBNAME_URL_VARIABLE, server.getServerId());
	server.setDbUri(dbUri);
	server.setDbUser(username);
	server.setDbPassword(password);
	server.setContainerId(containerId);
	dockerHelper.runDbContainer(containerId, server.getDbUri(), username, password);
	}

[wikumChamith]

@mherman22 I see the error message even the first time SDK prompts for credentials. Can we avoid that?

Database connection failed (attempt 1 of 3): Invalid database credentials. Please check your username and password.

Sorry this was an issue on my side :)

[mherman22]

This all looks like a nice improvement to me. I do think it would be ideal if we could keep all of the prompting in the wizard itself, and of course the URL could also be wrong, not just the username and password, so giving a chance to fix that might also be worthwhile (eg. maybe the wrong database name was used, or maybe the wrong database option was chosen). I'm happy enough to see this get committed as is, and leave that for another day if needed though.

I'm working on a followup commit for this