add support for oereblex api version 1.2.5 #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
- Coverage 99.64% 99.35% -0.29%
==========================================
Files 4 5 +1
Lines 279 309 +30
==========================================
+ Hits 278 307 +29
- Misses 1 2 +1 |
| @@ -1,10 +1,12 @@ | |||
| # -*- coding: utf-8 -*- | |||
| """ Provides classes for parsing the xml document from the geolink api. """ | |||
| from importlib import resources as impresources | |||
Check warning
Code scanning / Pylint (reported by Codacy)
No name 'resources' in module 'importlib' Warning
michmuel
force-pushed
the
330-oereblex-api-version-1-2-5
branch
from
00ef710 to
fc4c63f
Compare
jwkaltz
reviewed
Dec 4, 2024
kdeininger
approved these changes
Dec 10, 2024
|
I was looking at the changes mostly from geolink2oereb point of view. And it looks ok for me. |
vvmruder
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support of oereblex api version 1.2.5
Changes: