Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade cypress to 12.17.4 #2306

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

ritvibhatt
Copy link
Contributor

@ritvibhatt ritvibhatt commented Jan 8, 2025

Description

Downgrade cypress version to 12.17.4 to match Opensearch Dashboards

Observability plugin is failing in dashboards distribution build because of different cypress versions:

ERROR [single_version_dependencies] Multiple version ranges for the same dependency
      were found declared across different package.json files. Please consolidate
      those to match across all package.json files. Different versions for the
      same dependency is not supported.

      The conflicting dependencies are:

        cypress
          12.17.4 => opensearch-dashboards
          ^13.6.0 => observability-dashboards

Tests in FTR will continue to fail until it uses distribution build that has observability plugin

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ritvibhatt ritvibhatt closed this Jan 8, 2025
@ritvibhatt ritvibhatt reopened this Jan 8, 2025
@ritvibhatt ritvibhatt marked this pull request as ready for review January 8, 2025 22:07
@RyanL1997 RyanL1997 merged commit 7d4dead into opensearch-project:main Jan 8, 2025
21 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 8, 2025
Co-authored-by: Ritvi Bhatt <[email protected]>
(cherry picked from commit 7d4dead)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam pushed a commit that referenced this pull request Jan 9, 2025
(cherry picked from commit 7d4dead)

Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ritvi Bhatt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants