Remove redundant traces call for related services #2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
ps48
added
traces
Signed-off-by: Shenoy Pratik <[email protected]>
joshuali925
approved these changes
Jan 24, 2025
| @@ -197,30 +196,6 @@ export const handleServiceMapRequest = async ( | |||
| } | |||
| } | |||
|
|
|||
| if (currService) { | |||
| await handleDslRequest(http, DSL, getRelatedServicesQuery(currService), mode, dataSourceMDSId) | |||
There was a problem hiding this comment.
also remove the function to get query if it's no longer used?
| } | ||
|
|
||
| // Add the related services to the map for the current service | ||
| map[currService].relatedServices = [...relatedServices]; |
There was a problem hiding this comment.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
* remove traces call for related services Signed-off-by: Shenoy Pratik <[email protected]> * remove call and update the number of traces to 500 Signed-off-by: Shenoy Pratik <[email protected]> * update snapshots Signed-off-by: Shenoy Pratik <[email protected]> --------- Signed-off-by: Shenoy Pratik <[email protected]> (cherry picked from commit a9610da) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
TackAdam
pushed a commit
that referenced
this pull request
Jan 24, 2025
* remove traces call for related services * remove call and update the number of traces to 500 * update snapshots --------- (cherry picked from commit a9610da) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Users were seeing high latency on the custom services page in trace analytics
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.