-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for search using the "fields" parameter with knn_vector field #2314
Merged
jmazanec15
merged 11 commits into
opensearch-project:main
from
e-emoto:fields-parameter-support
Jan 14, 2025
Merged
Add support for search using the "fields" parameter with knn_vector field #2314
jmazanec15
merged 11 commits into
opensearch-project:main
from
e-emoto:fields-parameter-support
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ethan Emoto <[email protected]>
e-emoto
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
December 7, 2024 03:39
@e-emoto please fix the failing CIs |
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
VijayanB
reviewed
Dec 10, 2024
VijayanB
reviewed
Dec 10, 2024
VijayanB
reviewed
Dec 10, 2024
Signed-off-by: Ethan Emoto <[email protected]>
navneet1v
reviewed
Dec 12, 2024
can you add the manual testing result on the PR? |
navneet1v
reviewed
Dec 12, 2024
navneet1v
reviewed
Dec 12, 2024
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
Signed-off-by: Ethan Emoto <[email protected]>
jmazanec15
reviewed
Jan 8, 2025
shatejas
reviewed
Jan 13, 2025
src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldType.java
Outdated
Show resolved
Hide resolved
shatejas
reviewed
Jan 13, 2025
src/main/java/org/opensearch/knn/index/mapper/KNNVectorFieldType.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ethan Emoto <[email protected]>
jmazanec15
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @e-emoto !
shatejas
approved these changes
Jan 14, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
…ield (#2314) Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde)
e-emoto
added a commit
to e-emoto/k-NN
that referenced
this pull request
Jan 21, 2025
…ield (opensearch-project#2314) Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde)
e-emoto
added a commit
to e-emoto/k-NN
that referenced
this pull request
Jan 21, 2025
…ield (opensearch-project#2314) Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde)
Merged
5 tasks
Created backport PR manually to fix issue with sign-off email: |
navneet1v
pushed a commit
that referenced
this pull request
Jan 23, 2025
…th knn_vector field (#2411) * Add support for search using the "fields" parameter with knn_vector field (#2314) Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde) * Fix NPE in backporting fields parameter ITs Signed-off-by: Ethan Emoto <[email protected]> * Mute testKNNWarmupCustomLegacyFieldMapping (#2416) Signed-off-by: Kunal Kotwani <[email protected]> --------- Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Kunal Kotwani <[email protected]> Co-authored-by: Kunal Kotwani <[email protected]>
e-emoto
added a commit
to e-emoto/k-NN
that referenced
this pull request
Jan 23, 2025
…ield (opensearch-project#2314) Signed-off-by: Ethan Emoto <[email protected]> Signed-off-by: Ethan Emoto <[email protected]> (cherry picked from commit 5c63fde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change implements valueFetcher in KNNVectorFieldType so search can support using the "fields" parameter when used with the knn_vector field type. ITs for this change were added to OpenSearchIT after the change was tested manually.
Manual Testing Output
Related Issues
Resolves #1633
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.