Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Disjuction query in HybridQueryPhaseSearcher #1127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

owaiskazi19
Copy link
Member

@owaiskazi19 owaiskazi19 commented Jan 21, 2025

Description

Validate Disjuction query in HybridQueryPhaseSearcher to avoid having hybrid as a nested query

{
    "query": {
        "dis_max": {
            "queries": [
                {
                    "match": {
                        "title": "Shakespeare poems"
                    }
                },
                {
                    "hybrid": {
                        "queries": [
                            {
                                "match": {
                                    "passage_text": {
                                        "query": "Hi world"
                                    }
                                }
                            }
                        ]
                    }
                }
            ]
        }
    }
}

Response

{
    "error": {
        "root_cause": [
            {
                "type": "illegal_argument_exception",
                "reason": "hybrid query must be a top level query and cannot be wrapped into other queries"
            }
        ],

Related Issues

Part of #1125

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please add a unit tests for this case?

log.error("reached max nested query limit, cannot process dis_max query with that many nested clauses");
return;
}
if (query instanceof DisjunctionMaxQuery) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it will work in case if one type of compound query is nested into another compound query type? E.g.

disjunction_max {
     bool {
            hybrid {
            }
      }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants