Change publishToMavenLocal to publishPluginToMavenLocal only #4437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
dblock,
peterzhuamazon,
bbarani,
gaiksaya,
rishabh6788,
zelinh,
jordarlu,
prudhvigodithi,
Divyaasm and
tianleh
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4437 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 190 190
Lines 6197 6197
=======================================
Hits 5661 5661
Misses 536 536 ☔ View full report in Codecov by Sentry. |
peterzhuamazon
approved these changes
Feb 9, 2024
There was a problem hiding this comment.
Approve this and will wait for @prudhvigodithi second approval and merge after his local test.
Thanks.
|
Thanks, I have tested 2.12 build on local with this change and looks good. |
prudhvigodithi
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change publishToMavenLocal to publishPluginToMavenLocal only
Issues Resolved
After this PR: #4434 merged, build for geospatial and opensearch-reports failed, this is to fix this issue.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.