Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update observability dashboards tests #1669

Merged
merged 14 commits into from
Jan 15, 2025

Conversation

ritvibhatt
Copy link
Contributor

@ritvibhatt ritvibhatt commented Dec 16, 2024

Description

Update traces and services tests to use data-test-subj instead of searching for string "Refresh" to click refresh button
Update notebooks to use just data-test-subj for checking header and updated delete button

Services:
Screenshot 2024-12-16 at 11 24 20 AM

Traces:
Screenshot 2024-12-16 at 11 25 02 AM

Notebooks:
Screenshot 2024-12-16 at 11 30 06 AM

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Ritvi Bhatt added 2 commits December 16, 2024 12:14
Signed-off-by: Ritvi Bhatt <[email protected]>
@ritvibhatt ritvibhatt marked this pull request as draft January 10, 2025 00:31
Ritvi Bhatt added 2 commits January 9, 2025 16:32
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
@ritvibhatt ritvibhatt marked this pull request as ready for review January 14, 2025 19:28
Copy link

@TackAdam TackAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CCongWang CCongWang merged commit 57db1eb into opensearch-project:main Jan 15, 2025
42 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1669-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57db1eb9a3e4bd72372963a9ceee8c4a153bc13d
# Push it to GitHub
git push --set-upstream origin backport/backport-1669-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1669-to-2.x.

ritvibhatt added a commit to ritvibhatt/opensearch-dashboards-functional-test that referenced this pull request Jan 15, 2025
* update observability dashboards tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* fix notebook delete

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip last reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* move notebook alias earlier

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip last reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* stop tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

---------

Signed-off-by: Ritvi Bhatt <[email protected]>
Co-authored-by: Ritvi Bhatt <[email protected]>
(cherry picked from commit 57db1eb)
CCongWang pushed a commit that referenced this pull request Jan 16, 2025
* update observability dashboards tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* fix notebook delete

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip last reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* move notebook alias earlier

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip last reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* stop tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* skip reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

* add back reporting tests

Signed-off-by: Ritvi Bhatt <[email protected]>

---------

Signed-off-by: Ritvi Bhatt <[email protected]>
Co-authored-by: Ritvi Bhatt <[email protected]>
(cherry picked from commit 57db1eb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants