-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update observability dashboards tests #1669
Merged
CCongWang
merged 14 commits into
opensearch-project:main
from
ritvibhatt:observability-fixes
Jan 15, 2025
Merged
Update observability dashboards tests #1669
CCongWang
merged 14 commits into
opensearch-project:main
from
ritvibhatt:observability-fixes
Jan 15, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
ritvibhatt
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam,
raintygao,
zhongnansu,
yujin-emma and
yubonluo
as code owners
December 16, 2024 22:02
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
Signed-off-by: Ritvi Bhatt <[email protected]>
TackAdam
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CCongWang
approved these changes
Jan 14, 2025
zhongnansu
approved these changes
Jan 15, 2025
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1669-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 57db1eb9a3e4bd72372963a9ceee8c4a153bc13d
# Push it to GitHub
git push --set-upstream origin backport/backport-1669-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
ritvibhatt
added a commit
to ritvibhatt/opensearch-dashboards-functional-test
that referenced
this pull request
Jan 15, 2025
* update observability dashboards tests Signed-off-by: Ritvi Bhatt <[email protected]> * fix notebook delete Signed-off-by: Ritvi Bhatt <[email protected]> * skip reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * skip last reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * move notebook alias earlier Signed-off-by: Ritvi Bhatt <[email protected]> * skip last reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * stop tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * skip reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> --------- Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 57db1eb)
1 task
CCongWang
pushed a commit
that referenced
this pull request
Jan 16, 2025
* update observability dashboards tests Signed-off-by: Ritvi Bhatt <[email protected]> * fix notebook delete Signed-off-by: Ritvi Bhatt <[email protected]> * skip reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * skip last reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * move notebook alias earlier Signed-off-by: Ritvi Bhatt <[email protected]> * skip last reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * stop tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * skip reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> * add back reporting tests Signed-off-by: Ritvi Bhatt <[email protected]> --------- Signed-off-by: Ritvi Bhatt <[email protected]> Co-authored-by: Ritvi Bhatt <[email protected]> (cherry picked from commit 57db1eb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update traces and services tests to use data-test-subj instead of searching for string "Refresh" to click refresh button
Update notebooks to use just data-test-subj for checking header and updated delete button
Services:
Traces:
Notebooks:
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.