Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve workspace import sample data tests #1671

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Jan 3, 2025

Description

  1. Improve workspace import sample data tests, no need to install / uninstall sample data many times to reduce the possibility of test flaky.
  2. Fix upload artifact failed due to duplicate artifact name

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@SuZhou-Joe SuZhou-Joe merged commit af6f753 into opensearch-project:main Jan 6, 2025
59 of 65 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 6, 2025
* Improve workspace import sample data tests

Signed-off-by: Lin Wang <[email protected]>

* Fix artifact upload failed for bundle snapshot

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit af6f753)
wanglam added a commit that referenced this pull request Jan 8, 2025
* Improve workspace import sample data tests

Signed-off-by: Lin Wang <[email protected]>

* Fix artifact upload failed for bundle snapshot

Signed-off-by: Lin Wang <[email protected]>

---------

Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit af6f753)

Co-authored-by: Lin Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants