-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Domain endpoint for compiling templates to schemas #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Swiddis
force-pushed
the
schema-compilation
branch
from
January 20, 2023 00:54
304f2a7
to
9daa1c2
Compare
YANG-DB
requested changes
Jan 23, 2023
service/src/main/kotlin/org/opensearch/simpleschema/action/CreateSimpleSchemaDomainRequest.kt
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/action/CreateSimpleSchemaDomainResponse.kt
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/action/GetSimpleSchemaDomainResponse.kt
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/action/SimpleSchemaDomainActions.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/action/SimpleSchemaDomainActions.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/domain/DomainRepository.kt
Outdated
Show resolved
Hide resolved
service/src/main/kotlin/org/opensearch/simpleschema/model/SchemaCompilationType.kt
Show resolved
Hide resolved
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
YANG-DB
approved these changes
Jan 28, 2023
{ | ||
"schemaEntityType": { | ||
"name": "Author", | ||
"objectId": "testAuthorObject", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change objectId to name
|
||
```json | ||
{ | ||
"objectId": "testSchema", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change objectId to name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the bulk of the routing work for the Domain endpoint, including basic functionality to combine templates into a schema object.
docs/schema-workflow.md
for usage instructions regarding this implementation.Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.