Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Domain endpoint for compiling templates to schemas #63

Merged
merged 17 commits into from
Jan 28, 2023

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Jan 20, 2023

Description

This PR contains the bulk of the routing work for the Domain endpoint, including basic functionality to combine templates into a schema object.

  • See this comment on issue 16 for more context on the endpoint
  • See docs/schema-workflow.md for usage instructions regarding this implementation.

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Swiddis Swiddis force-pushed the schema-compilation branch from 304f2a7 to 9daa1c2 Compare January 20, 2023 00:54
@YANG-DB YANG-DB self-requested a review January 26, 2023 02:15
Signed-off-by: Simeon Widdis <[email protected]>
Signed-off-by: Simeon Widdis <[email protected]>
{
"schemaEntityType": {
"name": "Author",
"objectId": "testAuthorObject",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change objectId to name


```json
{
"objectId": "testSchema",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change objectId to name

@YANG-DB YANG-DB merged commit 34a95b9 into opensearch-project:main Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Compiling templates into schemas
2 participants