Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] fixPPLAllowedFields #182

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 9174e4c from #181.

* fixPPLAllowedFields

Signed-off-by: xinyual <[email protected]>

* rename variables

Signed-off-by: xinyual <[email protected]>

---------

Signed-off-by: xinyual <[email protected]>
(cherry picked from commit 9174e4c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (41606a8) 81.63% compared to head (082e702) 81.80%.

Files Patch % Lines
.../main/java/org/opensearch/agent/tools/PPLTool.java 82.14% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #182      +/-   ##
============================================
+ Coverage     81.63%   81.80%   +0.16%     
  Complexity      196      196              
============================================
  Files            13       13              
  Lines          1002     1022      +20     
  Branches        132      134       +2     
============================================
+ Hits            818      836      +18     
- Misses          135      136       +1     
- Partials         49       50       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xinyual xinyual merged commit 005b4af into 2.x Feb 4, 2024
15 checks passed
@github-actions github-actions bot deleted the backport/backport-181-to-2.x branch February 4, 2024 08:24
yuye-aws pushed a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
* fixPPLAllowedFields

* rename variables

---------

(cherry picked from commit 9174e4c)

Signed-off-by: xinyual <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant