Fix alert constructor #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
joshuali925
approved these changes
Feb 6, 2024
|
ITs are failing, please help take a look. |
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
|
Alerting tests all passing now: |
|
@zane-neo can you re-review? |
owaiskazi19
approved these changes
Feb 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Fix alert constructor Signed-off-by: Tyler Ohlsen <[email protected]> * Update alert mapping Signed-off-by: Tyler Ohlsen <[email protected]> * Change sample alert example Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e323660) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Fix alert constructor * Update alert mapping * Change sample alert example --------- (cherry picked from commit e323660) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Fix alert constructor Signed-off-by: Tyler Ohlsen <[email protected]> * Update alert mapping Signed-off-by: Tyler Ohlsen <[email protected]> * Change sample alert example Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit e323660) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Feb 7, 2024
* Fix alert constructor * Update alert mapping * Change sample alert example --------- (cherry picked from commit e323660) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
* Fix alert constructor * Update alert mapping * Change sample alert example --------- (cherry picked from commit e323660) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
Alertconstructor caused by this breaking change from alerting team. opensearch-project/common-utils#584Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.