Onboard search AD and search monitor tools to security-enabled IT #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Ohlsen <[email protected]>
ohltyler
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90,
zhichao-aws and
joshuali925
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=========================================
Coverage 81.69% 81.69%
Complexity 206 206
=========================================
Files 13 13
Lines 1060 1060
Branches 141 141
=========================================
Hits 866 866
Misses 140 140
Partials 54 54 ☔ View full report in Codecov by Sentry. |
dbwiddis
approved these changes
Feb 13, 2024
joshpalis
approved these changes
Feb 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 13, 2024
Signed-off-by: Tyler Ohlsen <[email protected]> (cherry picked from commit 4cecb3d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ohltyler
pushed a commit
that referenced
this pull request
Feb 13, 2024
(cherry picked from commit 4cecb3d) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…-project#225) (opensearch-project#226) (cherry picked from commit 4cecb3d) Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Onboards
SearchAnomalyDetectorsToolandSearchMonitorsToolto the security-enabled integ tests. These were originally skipped due to system index manipulation logic by the REST client that was blocked by the security plugin in security-enabled tests. This PR removes that system index manipulation logic for these particular tools, and removes the skipped files inbuild.gradle. Instead of deletion and re-creation of system indices, we now just delete the created resources on a per-test basis, and run the tests in a particular order to still test the no-system-index case. Helper fns added to support this.Note that we still have to skip for
SearchAnomalyResultsToolandSearchAlertsTool. That's because there is no fast way to populate results to search on without direct system index manipulation. Added a comment to clarify.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.