[Backport 2.x] Change job-scheduler plugin group to point to correct location #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Change job-scheduler plguin group to point to correct localtion Signed-off-by: zane-neo <[email protected]> * Add publish task Signed-off-by: zane-neo <[email protected]> * add dependency task to publishToStagingRepo Signed-off-by: zane-neo <[email protected]> * Fix publishAllPublicationsToStagingRepository failure issue Signed-off-by: zane-neo <[email protected]> * add comment to JS plugin path Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 37bbd3b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #60 +/- ##
=========================================
Coverage 45.17% 45.17%
Complexity 30 30
=========================================
Files 6 6
Lines 352 352
Branches 42 42
=========================================
Hits 159 159
Misses 172 172
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Dec 26, 2023
| @@ -119,7 +119,8 @@ dependencies { | |||
|
|
|||
| // ZipArchive dependencies used for integration tests | |||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-ml-plugin', version: "${version}" | |||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-job-scheduler', version: "${version}" | |||
| //JS plugin is published to `org/opensearch` instead of `org/opensearch/plugin` under local maven repo: https://mvnrepository.com/artifact/org.opensearch/opensearch-job-scheduler. | |||
| zipArchive group: 'org.opensearch', name:'opensearch-job-scheduler', version: "${version}" | |||
There was a problem hiding this comment.
we also have https://mvnrepository.com/artifact/org.opensearch.plugin/opensearch-job-scheduler
And the groupId is org.opensearch.plugin defined here https://github.com/opensearch-project/job-scheduler/blob/main/build.gradle#L131
There was a problem hiding this comment.
Job-scheduler is not publishing plugin zip in publishToMavenLocal task so can't find plugin in local repo, changing this makes it points to jar file directly, but I checked again and found we'd better directly depend on jars instead of zip for both job-scheduler and anomaly-detection. I've created this PR to fix this: #74. We can merge this one and then backport that PR after merged to main.
zane-neo
approved these changes
Dec 27, 2023
yuye-aws
pushed a commit
to yuye-aws/skills
that referenced
this pull request
Apr 26, 2024
…earch-project#56) (opensearch-project#60) * Change job-scheduler plguin group to point to correct localtion * Add publish task * add dependency task to publishToStagingRepo * Fix publishAllPublicationsToStagingRepository failure issue * add comment to JS plugin path --------- (cherry picked from commit 37bbd3b) Signed-off-by: zane-neo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: yuye-aws <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 37bbd3b from #56.