[Backport 2.x] Change js to jar dependency #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
dbwiddis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
ohltyler
reviewed
Dec 29, 2023
build.gradle
Outdated
| @@ -70,15 +70,14 @@ apply plugin: 'opensearch.testclusters' | |||
| apply plugin: 'opensearch.pluginzip' | |||
|
|
|||
| def sqlJarDirectory = "$buildDir/dependencies/opensearch-sql-plugin" | |||
| def jsJarDirectory = "$buildDir/dependencies/opensearch-job-scheduler" | |||
| def adJarDirectory = "$buildDir/dependencies/opensearch-anomaly-detection" | |||
| def adJarDirectory = "$buildDir/dependencies/opensearch-time-series-analytics" | |||
There was a problem hiding this comment.
Any reference to time-series-analytics should be reverted to anomaly-detection. The name change is only tracked on main.
…tection Signed-off-by: zane-neo <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #80 +/- ##
=========================================
Coverage 82.18% 82.18%
Complexity 151 151
=========================================
Files 12 12
Lines 870 870
Branches 115 115
=========================================
Hits 715 715
Misses 97 97
Partials 58 58 ☔ View full report in Codecov by Sentry. |
|
This change could cause gradle run error, closing this and will create another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change js to jar dependency, backport of: #74
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.