Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close stale PRs after 60 days of inactivity #3222

Closed

Conversation

Swiddis
Copy link
Collaborator

@Swiddis Swiddis commented Dec 27, 2024

Description

Updates the stalled PRs action to close PRs that have been inactive for 60 days (marked "stalled" for 30 days). In general the stale PRs tend to not get addressed anyways, we currently have 14 PRs with no activity for 200 days. This is a logical followup to #3221, I want to make it a separate PR for dedicated discussion.

Note that closing PRs isn't a destructive action, authors can easily reopen them if they get falsely closed. It just keeps our pending list more tidy, and also encourages authors to push again for feedback if they believe their changes are relevant and aren't getting attention.

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Simeon Widdis <[email protected]>
days-before-pr-stale: 30
days-before-issue-stale: -1
days-before-pr-close: -1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just being curious, was this not even enabled before? Why it was -1 here?

@anasalkouz
Copy link
Member

I don't think we need to auto-close PR by default. Maintainers need to review stalled PR and take the proper action case by case.

@Swiddis
Copy link
Collaborator Author

Swiddis commented Jan 6, 2025

I think it helps -- for the most part longstanding stale PRs fall into three categories that are all helped by this:

  • Relevant, Pending author action: If the author has abandoned the PR, having an automated message and workflow communicates clearly what the next steps are, and removes workload from maintainers to play the guessing game of "Have they abandoned it long enough?". The alternative is to manually recreate this behavior which will be more inconsistent.
  • Relevant, Pending maintainer action: Maintainers have a definite timeframe to work with and can't leave PRs sitting around, author knows they need to re-request maintainer action. Not having the action will make this slower/fuzzier.
  • No longer applicable: less maintainer workload to have it auto-closed, forces maintainers to make decisions on PR applicability in the short-term to keep the review queue smaller.

@Swiddis
Copy link
Collaborator Author

Swiddis commented Jan 7, 2025

Not planned after side-channel discussion

@Swiddis Swiddis closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Improves code quality, but not the product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants