-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-45847: Remove barrel files references in static plugin exposed modules #14683
base: master
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
@logonoff: This pull request references Jira Issue OCPBUGS-45847, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f26c04f
to
c509284
Compare
affe0d7
to
f20fd7a
Compare
@logonoff: This pull request references Jira Issue OCPBUGS-45847, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
c945e0b
to
24a0630
Compare
b9bfe32
to
cef6f70
Compare
/retest |
@logonoff: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
removed references to files that are exposed by a static plugin but is not used by it, and remove files entirely if not referenced elsewhere. also fix an import cycle
cef6f70
to
698dffa
Compare
CONSOLE Features and Fixes:
https://issues.redhat.com/browse/OCPBUGS-45847
Solution description
I removed all index file imports in the
exposedModules
field and replaced them with their direct counterparts, then removed the index file. I did not do this forpipelines-plugin
(and instead suppressed the build warning you get from using index files) as it is being moved to a dynamic pluginReviewers and assignees:
Code reviewer:
/cc @vojtechszocs
Test cases:
Nothing should change to the user