Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-45847: Remove barrel files references in static plugin exposed modules #14683

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jan 16, 2025

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/OCPBUGS-45847

Solution description

I removed all index file imports in the exposedModules field and replaced them with their direct counterparts, then removed the index file. I did not do this for pipelines-plugin (and instead suppressed the build warning you get from using index files) as it is being moved to a dynamic plugin

Reviewers and assignees:

Code reviewer:

/cc @vojtechszocs

Test cases:

Nothing should change to the user

@openshift-ci openshift-ci bot requested a review from vojtechszocs January 16, 2025 06:26
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-45847, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/OCPBUGS-45847

Solution description

Rewrote any index file imports in the exposedModules field to no longer use them. Did not do pipelines-plugin and instead suppressed the warning as it is being moved to a dynamic plugin

Reviewers and assignees:

Code reviewer:

/cc @vojtechszocs

Test cases:

Nothing should change to the user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology labels Jan 16, 2025
@logonoff logonoff force-pushed the OCPBUGS-45847-unbarrel branch 2 times, most recently from f26c04f to c509284 Compare January 16, 2025 13:23
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jan 16, 2025
@logonoff logonoff force-pushed the OCPBUGS-45847-unbarrel branch from affe0d7 to f20fd7a Compare January 16, 2025 16:28
@logonoff logonoff marked this pull request as ready for review January 16, 2025 16:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-45847, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

CONSOLE Features and Fixes:

https://issues.redhat.com/browse/OCPBUGS-45847

Solution description

I removed all index file imports in the exposedModules field and replaced them with their direct counterparts, then removed the index file. I did not do this for pipelines-plugin (and instead suppressed the build warning you get from using index files) as it is being moved to a dynamic plugin

Reviewers and assignees:

Code reviewer:

/cc @vojtechszocs

Test cases:

Nothing should change to the user

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the OCPBUGS-45847-unbarrel branch 3 times, most recently from c945e0b to 24a0630 Compare January 17, 2025 15:33
@logonoff logonoff force-pushed the OCPBUGS-45847-unbarrel branch 2 times, most recently from b9bfe32 to cef6f70 Compare January 17, 2025 21:50
@logonoff
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Jan 18, 2025

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console cef6f70 link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff force-pushed the OCPBUGS-45847-unbarrel branch from cef6f70 to 698dffa Compare January 19, 2025 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dev-console Related to dev-console component/helm Related to helm-plugin component/knative Related to knative-plugin component/network-attachment-definition Related to network-attachment-definition component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared component/topology Related to topology jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants