This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Improvments for MCollective Client/Server Origin vs OSE #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshentRas
commented
May 29, 2015
IshentRas
commented
- Deleted mcollective.service as it is not in used for OpenShift
- Reported new options introduced by OSE
- Improved indentation of the mcollective-client.cfg.erb and mcollective-server.cfg.erb
… OSE) - Deleted mcollective.service as it is not in used for OpenShift - Reported new options introduced by OSE - Improved indentation of the mcollective-client.cfg.erb and mcollective-server.cfg.erb
| # # https://bugzilla.redhat.com/show_bug.cgi?id=963332 | ||
| logger_type = console | ||
| loglevel = warn | ||
| <% else -%> |
There was a problem hiding this comment.
So, this works in origin but not ose? That seems odd as I doubt we're customizing mcollective. John is assigned the referenced bug, lets see what he says, ping @dobbymoodge
There was a problem hiding this comment.
Sorry, I inverted the conditional in my head here. So this would be enabled only for OSE.
I think if the fix works for origin as well we can go ahead and fix it for origin too. The other items in your previous pull requests that were places where variable names differed between Origin M4 and OSE 2.2 so we had no option but to conditionalize it.
There was a problem hiding this comment.
@sdodson you have never come back to me regarding this one :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.