Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EcoSynthesisX.yaml #307

Closed
wants to merge 3 commits into from
Closed

Create EcoSynthesisX.yaml #307

wants to merge 3 commits into from

Conversation

PaulBurgEth
Copy link

Approving request

@PaulBurgEth PaulBurgEth temporarily deployed to external-prs-app May 28, 2024 08:39 — with GitHub Actions Inactive
@PaulBurgEth
Copy link
Author

/validate 29967f7

ryscheng
ryscheng reviewed May 28, 2024
View reviewed changes
data/projects/e/EcoSynthesisX.yaml Outdated
github:
- url: https://github.com/EcoSynthesisX
npm:
- url: https://www.npmjs.com/package/oss-directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should only be used to enumerate your own npm packages. Please remove oss-directory

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Deleted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Sorry, I'm not really deep in code. Did I do proper correction for the file? Are we on Open Source Observer?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we merge this in, it should start indexing your project. Let me look at this now. Thanks!

@PaulBurgEth PaulBurgEth temporarily deployed to external-prs-app May 29, 2024 03:06 — with GitHub Actions Inactive
@ryscheng
Copy link
Member

/validate 35a37c4

@ryscheng
Copy link
Member

@PashaBurg I think the YAML isn't properly formatted, check these logs:
https://github.com/opensource-observer/oss-directory/actions/runs/9279629186/job/25606642487?pr=307

The best way to check locally is to run

pnpm install
pnpm validate

Can you help fix these errors first?

@PaulBurgEth PaulBurgEth temporarily deployed to external-prs-app May 31, 2024 03:33 — with GitHub Actions Inactive
@PaulBurgEth
Copy link
Author

Corrected .yaml done ✅

@PaulBurgEth
Copy link
Author

/validate f794735

@PaulBurgEth
Copy link
Author

@ryscheng Hello! Can you support on the next step? Should I initiate process somehow?

@ccerv1
Copy link
Member

ccerv1 commented Jun 3, 2024

hey @PashaBurg we already have your project in OSS Directory 🎉
I've added the missing deployer from your PR in my new PR. I'll close at your PR and we should be good to go!

Here's the latest version. If you see any issues, please open a new PR. Thanks again!

@ccerv1 ccerv1 closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryscheng ryscheng ryscheng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulBurgEth @ryscheng @ccerv1