Add parameters to specify maximum allowd time jump #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taka-Kazu
approved these changes
Apr 22, 2024
| { | ||
| if (g_P_set[YP_PARAM_MAX_TIME_JUMP_NEG][0] <= 0) | ||
| { | ||
| yprintf(OUTPUT_LV_ERROR, "ERROR: -MAX_TIME_JUMP must be > 0.0.\n"); |
There was a problem hiding this comment.
[optional] MAX_TIME_JUMP is another parameter so use the name MAX_TIME_JUMP_NEG might be clearer here.
Suggested change
| yprintf(OUTPUT_LV_ERROR, "ERROR: -MAX_TIME_JUMP must be > 0.0.\n"); | |
| yprintf(OUTPUT_LV_ERROR, "ERROR: MAX_TIME_JUMP_NEG must be > 0.0.\n"); |
There was a problem hiding this comment.
MAX_TIME_JUMP_NEG is internal enum name and user can only specify -MAX_TIME_JUMP in the parameter file.
(This format was originally introduced to support different friction parameters for each rotation direction)
at-wat
commented
Apr 22, 2024
src/param.c
Outdated
| @@ -940,6 +940,36 @@ int set_paramptr(FILE* paramfile) | |||
| g_P_changed[YP_PARAM_TORQUE_UNIT][j] = ischanged_p(YP_PARAM_TORQUE_FINENESS, j); | |||
| } | |||
|
|
|||
| if (g_P_set[YP_PARAM_MAX_TIME_JUMP][0]) | |||
| { | |||
| if (g_P_set[YP_PARAM_MAX_TIME_JUMP][0] <= 0) | |||
There was a problem hiding this comment.
Suggested change
| if (g_P_set[YP_PARAM_MAX_TIME_JUMP][0] <= 0) | |
| if (g_P[YP_PARAM_MAX_TIME_JUMP][0] <= 0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.