-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport default.yaml split patches #394
Backport default.yaml split patches #394
Conversation
This looks fine to me. @cjeanner @eduolivares @eshulman2 please let me know when you think it's safe to merge. |
Once we get proper testing results, we should be able to merge. I've updated the Depends-On on the ci-framework PR that backports the needed change as well. |
- name: Deploy Ceph | ||
type: playbook | ||
source: "../../playbooks/ceph.yml" | ||
inventory: "${HOME}/ci-framework-data/artifacts/zuul_inventory.yml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please match this file content with https://github.com/openstack-k8s-operators/architecture/blob/main/automation/vars/nfv-ovs-dpdk-sriov-hci.yaml
It backports following patches: openstack-k8s-operators#375 - Move automation default vars into seperate scenario files openstack-k8s-operators#383 - Drop default.yaml file openstack-k8s-operators#379 - Ensure we have one scenario per automation file openstack-k8s-operators#384 - Move bgp_dt01 into its own automation file openstack-k8s-operators#373 - NFV-HCI minor fixes Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
23a4e5d
to
613f451
Compare
lgtm |
lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
I took care of the ci-framework - will force-merge if prow's too slow there.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cjeanner, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build succeeded (gate pipeline). ✔️ noop SUCCESS in 0s |
ab2e02a
into
openstack-k8s-operators:18.0.0-proposed
It backports following patches: