Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Heat for uni04delta-ipv6 DT #415

Conversation

gmarcian
Copy link
Contributor

@gmarcian gmarcian commented Oct 9, 2024

It was a cherry-picked from #411

Copy link

openshift-ci bot commented Oct 9, 2024

Hi @gmarcian. Thanks for your PR.

I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abays
Copy link
Contributor

abays commented Oct 11, 2024

/ok-to-test

@abays
Copy link
Contributor

abays commented Oct 11, 2024

Has this been tried in a testproject job?

@gmarcian
Copy link
Contributor Author

@abays It's being tested here: https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/698

@abays
Copy link
Contributor

abays commented Oct 11, 2024

@abays It's being tested here: https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/698

Awesome. Once that succeeds I think we can merge.

@gmarcian
Copy link
Contributor Author

@abays
Copy link
Contributor

abays commented Oct 18, 2024

Copy link

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, gmarcian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit c63e759 into openstack-k8s-operators:18.0.0-proposed Oct 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants