Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DCN] Explicitly set network availability zone parameters #440

Merged

Conversation

sbekkerm
Copy link
Contributor

This patch explicitly sets the network availability zone parameters to their default values, enabling the configuration of availability zones for DCN sites if needed.

@openshift-ci openshift-ci bot requested review from fultonj and leifmadsen November 11, 2024 16:39
@fultonj
Copy link
Contributor

fultonj commented Nov 11, 2024

Run test-kustomization script fails with

examples/dt/dcn/kustomization.yaml: ERROR
Error: accumulating components: accumulateDirectory: "recursed accumulation of path '/home/runner/work/architecture/architecture/dt/dcn/edpm-post-ceph/nodeset': fieldPath `data.ovn.template.ovnController.external-ids.availability-zones` is missing for replacement source ConfigMap.[noVer].[noGrp]/service-values.[noNs]"

https://github.com/openstack-k8s-operators/architecture/actions/runs/11782586725/job/32817945322?pr=440

@fultonj fultonj removed the request for review from leifmadsen November 11, 2024 16:42
@sbekkerm sbekkerm force-pushed the dcn_net_az branch 2 times, most recently from 09ba792 to bb784fb Compare November 13, 2024 17:31
This patch explicitly sets the network availability zone parameters to their default values,
enabling configuration of availability zones for DCN sites if needed.
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, sbekkerm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/fbfd597a4dc440d69d5f7d76110d4fee

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-dcn SUCCESS in 3m 19s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit b7fcd01 into openstack-k8s-operators:main Nov 15, 2024
7 checks passed
@sbekkerm
Copy link
Contributor Author

/cherrypick 18.0-fr1

@openshift-cherrypick-robot

@sbekkerm: new pull request created: #446

In response to this:

/cherrypick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants