Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused ocp values service and cluster cidr #450

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Drop unused ocp values service and cluster cidr #450

merged 1 commit into from
Nov 18, 2024

Conversation

hjensas
Copy link
Contributor

@hjensas hjensas commented Nov 18, 2024

These values are not used anywhere, let's remove them from the example.

@hjensas
Drop unused ocp values service and cluster cidr
ae03b3e 
These values are not used anywhere, let's remove them from the example.
@hjensas
Copy link
Contributor Author

hjensas commented Nov 18, 2024

@abays @fultonj - please vote negative if I got this wrong.

fultonj
fultonj approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@fultonj fultonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

I agree they are not used anywhere as per a grep of ci-framework, ci-framwork-jobs and architecture. The proposer of this patch is the one who originally added them so I feel enough diligence has been taken to remove them.

3074913#diff-5448b0def9b2d2f183cb645f2d715053e5f291a6304e15531cc695a17ba0eb1d

@openshift-ci openshift-ci bot added the lgtm label Nov 18, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fultonj, hjensas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/acd51fb181354a04b12fcb4ac77cbd4f

✔️ noop SUCCESS in 0s
✔️ rhoso-architecture-validate-bmo01 SUCCESS in 3m 50s
✔️ rhoso-architecture-validate-uni01alpha SUCCESS in 3m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d60373f into openstack-k8s-operators:main Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fultonj fultonj fultonj approved these changes

@leifmadsen leifmadsen Awaiting requested review from leifmadsen

@raukadah raukadah Awaiting requested review from raukadah

Assignees

@fultonj fultonj

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjensas @fultonj