Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save kuttl JUnitXML result files #2598

Merged

Conversation

tosky
Copy link
Contributor

@tosky tosky commented Dec 12, 2024

Grab the results JUnitXML file (if any) returned by kuttl tests (they may not be configured to do so, so ignore the failures) and copy them to a location that will be collected.

Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tosky added a commit to tosky/manila-operator that referenced this pull request Dec 12, 2024
- fix the type (it is 'xml' lowercase, not uppercase);
- tune the name a bit to highlight it is a report;
- add the new reportGranularity parameter which will be supported
  by kuttl 1.20 and will restore the pre-1.17 JUnitXML format
  (granularity by test case, instead of by step).

Depends-On: openstack-k8s-operators/ci-framework#2598
Signed-off-by: Luigi Toscano <[email protected]>
@tosky tosky force-pushed the save-kuttl-junitxml branch from dcdc007 to 8377231 Compare December 13, 2024 19:55
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2d55c1e445e4eecb46df73550d9689f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 28s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 54s
cifmw-crc-podified-edpm-baremetal FAILURE in 48m 20s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 31s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 07s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 25m 16s
✔️ build-push-container-cifmw-client SUCCESS in 21m 10s

@tosky tosky force-pushed the save-kuttl-junitxml branch 2 times, most recently from bcc17b6 to 85456b7 Compare December 16, 2024 10:05
@tosky tosky marked this pull request as ready for review December 16, 2024 10:05
@tosky
Copy link
Contributor Author

tosky commented Dec 16, 2024

Ready for review! It was tested here: openstack-k8s-operators/manila-operator#376 , and people with the proper access level, in the logs of the last run you can see:

2024-12-13 20:00:34.662513 | controller | TASK [Copy the generated logs to the test results directory _raw_params=pwd

and the expected log file is visible in the logs:
controller/ci-framework-data/tests/kuttl_manila/kuttl-report-manila.xml

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40b3472c51774873905b304c2ff3c10f

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 17m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 23m 41s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 11s
cifmw-multinode-kuttl FAILURE in 25m 55s
✔️ build-push-container-cifmw-client SUCCESS in 21m 11s

tosky added a commit to tosky/manila-operator that referenced this pull request Dec 16, 2024
- fix the type (it is 'xml' lowercase, not uppercase);
- tune the name a bit to highlight it is a report;
- add the new reportGranularity parameter which is supported
  by kuttl 0.20.0 and will restore the pre-1.17 JUnitXML format
  (granularity by test case, instead of by step).

Depends-On: openstack-k8s-operators/ci-framework#2598
Signed-off-by: Luigi Toscano <[email protected]>
@pablintino pablintino requested a review from a team December 16, 2024 12:37
@tosky tosky force-pushed the save-kuttl-junitxml branch from 85456b7 to a436be5 Compare December 16, 2024 13:35
@tosky tosky requested a review from lewisdenny as a code owner December 16, 2024 13:35
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ceefbc8661843bc86fb317c61e0c203

openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705137 failed in 0s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 45s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 25s
✔️ cifmw-multinode-kuttl SUCCESS in 2h 13m 20s
✔️ build-push-container-cifmw-client SUCCESS in 36m 50s

@tosky
Copy link
Contributor Author

tosky commented Dec 17, 2024

Updated, thanks for the hints. The new code seems to work too.

@pablintino
Copy link
Collaborator

/approve

Copy link
Contributor

openshift-ci bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ci/playbooks/kuttl/run-kuttl-tests.yml Outdated Show resolved Hide resolved
ci/playbooks/kuttl/run-kuttl-tests.yml Outdated Show resolved Hide resolved
ci/playbooks/kuttl/run-kuttl-tests.yml Outdated Show resolved Hide resolved
Grab the results JUnitXML file (if any) returned by kuttl tests
(they may not be configured to do so, so ignore the failures)
and copy them to a location that will be collected.
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d4072ba into openstack-k8s-operators:main Dec 18, 2024
4 checks passed
@tosky
Copy link
Contributor Author

tosky commented Dec 18, 2024

/cherry-pick 18.0-fr1

@openshift-cherrypick-robot

@tosky: new pull request created: #2616

In response to this:

/cherry-pick 18.0-fr1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants