-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save kuttl JUnitXML result files #2598
Save kuttl JUnitXML result files #2598
Conversation
Skipping CI for Draft Pull Request. |
- fix the type (it is 'xml' lowercase, not uppercase); - tune the name a bit to highlight it is a report; - add the new reportGranularity parameter which will be supported by kuttl 1.20 and will restore the pre-1.17 JUnitXML format (granularity by test case, instead of by step). Depends-On: openstack-k8s-operators/ci-framework#2598 Signed-off-by: Luigi Toscano <[email protected]>
dcdc007
to
8377231
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/f2d55c1e445e4eecb46df73550d9689f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 30m 28s |
bcc17b6
to
85456b7
Compare
Ready for review! It was tested here: openstack-k8s-operators/manila-operator#376 , and people with the proper access level, in the logs of the last run you can see: 2024-12-13 20:00:34.662513 | controller | TASK [Copy the generated logs to the test results directory _raw_params=pwd and the expected log file is visible in the logs: |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/40b3472c51774873905b304c2ff3c10f ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 43m 12s |
- fix the type (it is 'xml' lowercase, not uppercase); - tune the name a bit to highlight it is a report; - add the new reportGranularity parameter which is supported by kuttl 0.20.0 and will restore the pre-1.17 JUnitXML format (granularity by test case, instead of by step). Depends-On: openstack-k8s-operators/ci-framework#2598 Signed-off-by: Luigi Toscano <[email protected]>
85456b7
to
a436be5
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ceefbc8661843bc86fb317c61e0c203 ❌ openstack-k8s-operators-content-provider NODE_FAILURE Node request 100-0007705137 failed in 0s |
a436be5
to
cfa117b
Compare
Updated, thanks for the hints. The new code seems to work too. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pablintino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Grab the results JUnitXML file (if any) returned by kuttl tests (they may not be configured to do so, so ignore the failures) and copy them to a location that will be collected.
cfa117b
to
4219411
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
d4072ba
into
openstack-k8s-operators:main
/cherry-pick 18.0-fr1 |
@tosky: new pull request created: #2616 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Grab the results JUnitXML file (if any) returned by kuttl tests (they may not be configured to do so, so ignore the failures) and copy them to a location that will be collected.