-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Envtest #291
Envtest #291
Conversation
/retest-required |
@ASBishop: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
- Relocate EnvTest code to test/functional - Update the test Makefile target - Redirect gotest Makefile target to test target - Remove webhook_suite_test.go
Add new cinder_test_data.go and base_test.go files by copying manila's files, and essentially s/manila/cinder/g and s/share/volume/g to convert the contents for use by cinder. Update suite_test.go using the same technique (copy manila's).
ReconcileRbac() should be called from reconcileNormal(), but when the code was added it was inadvertently added to reconcileInit().
The code is based on manila's, with updates relavant to cinder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ASBishop, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ff5f68
into
openstack-k8s-operators:main
…rators/renovate/openstack-k8s-operators Update openstack-k8s-operators
This is a short series of patches that adds functional tests for the cinder controller.