Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Envtest #291

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

ASBishop
Copy link
Contributor

@ASBishop ASBishop commented Nov 6, 2023

This is a short series of patches that adds functional tests for the cinder controller.

@ASBishop ASBishop requested review from fmount and Akrog November 6, 2023 22:35
@openshift-ci openshift-ci bot requested review from dprince and lewisdenny November 6, 2023 22:35
@openshift-ci openshift-ci bot added the approved label Nov 6, 2023
@ASBishop
Copy link
Contributor Author

ASBishop commented Nov 7, 2023

/retest-required

Copy link
Contributor

openshift-ci bot commented Nov 7, 2023

@ASBishop: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 083f976 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

- Relocate EnvTest code to test/functional
- Update the test Makefile target
- Redirect gotest Makefile target to test target
- Remove webhook_suite_test.go
Add new cinder_test_data.go and base_test.go files by copying
manila's files, and essentially s/manila/cinder/g and
s/share/volume/g to convert the contents for use by cinder.

Update suite_test.go using the same technique (copy manila's).
ReconcileRbac() should be called from reconcileNormal(), but when
the code was added it was inadvertently added to reconcileInit().
The code is based on manila's, with updates relavant to cinder.
Copy link
Contributor

@fmount fmount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ASBishop, fmount

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7ff5f68 into openstack-k8s-operators:main Nov 9, 2023
1 check passed
@ASBishop ASBishop deleted the envtest branch November 10, 2023 19:24
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
…rators/renovate/openstack-k8s-operators

Update openstack-k8s-operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants