Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module golang.org/x/net to v0.19.0 - autoclosed #304

Closed
wants to merge 1 commit into from

Conversation

openstack-k8s-ci-robot
Copy link

@openstack-k8s-ci-robot openstack-k8s-ci-robot commented Dec 2, 2023

This PR contains the following updates:

Package Type Update Change
golang.org/x/net replace minor v0.18.0 -> v0.19.0

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/New_York, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openshift-ci openshift-ci bot requested review from ASBishop and viroel December 2, 2023 07:36
Copy link
Contributor

openshift-ci bot commented Dec 2, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openstack-k8s-ci-robot
Once this PR has been reviewed and has the lgtm label, please assign stuggi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openstack-k8s-ci-robot openstack-k8s-ci-robot force-pushed the renovate/golang.org-x-net-0.x branch from 3d63e77 to d19095c Compare December 3, 2023 08:28
@ASBishop
Copy link
Contributor

ASBishop commented Dec 8, 2023

/retest

@@ -71,4 +71,4 @@ require (
replace github.com/openshift/api => github.com/openshift/api v0.0.0-20230414143018-3367bc7e6ac7 //allow-merging

// Bump golang.org/x/net to avoid Rapid Reset CVE
replace golang.org/x/net => golang.org/x/net v0.18.0 //allow-merging
replace golang.org/x/net => golang.org/x/net v0.19.0 //allow-merging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprince this stuff is obsolete now, right? L46 shows we're already using v0.19.0 and are well past the version that addresses the rapid reset CVE.

I don't know how renovate works, so do we just push an update to this PR that removes L73..L74?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could drop these replace lines now. It was basically done to clean up the go.sum on dev-preview2 (which could have references to the older x/net version effected by the CVE). Technically speaking though I don't that that causes us any issues as go.mod controls which version our operator uses

@openstack-k8s-ci-robot openstack-k8s-ci-robot changed the title Update module golang.org/x/net to v0.19.0 Update module golang.org/x/net to v0.19.0 - autoclosed Jan 8, 2024
@openstack-k8s-ci-robot openstack-k8s-ci-robot deleted the renovate/golang.org-x-net-0.x branch January 8, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants