Switch cinder-api to a statefulset #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASBishop
force-pushed
the
c-api-statefulset
branch
from
5938122 to
486345c
Compare
fmount
requested changes
Dec 13, 2023
| @@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1 | |||
| kind: CustomResourceDefinition | |||
| metadata: | |||
| annotations: | |||
| controller-gen.kubebuilder.io/version: v0.11.1 | |||
| controller-gen.kubebuilder.io/version: v0.10.0 | |||
There was a problem hiding this comment.
you probably have an older version of controller-gen within your repo because this shouldn't change.
(the same comment applies to the other files).
There was a problem hiding this comment.
whoa! I knew I was working on an older system that has an old controller-gen, but accidentally "git add -u" when I only meant to update a single file.
ASBishop
force-pushed
the
c-api-statefulset
branch
2 times, most recently
from
cd5f5c7 to
096bec0
Compare
|
/retest |
Change cinder-api from a deployment to a statefulset. Although the service doesn't require preserving stateful data, it helps with the pod naming convention so they're similar to glance-api pods, and eliminates the squirrely suffixes like "cinder-api-xzkpl"
ASBishop
force-pushed
the
c-api-statefulset
branch
from
096bec0 to
12edd83
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ASBishop, fmount The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 31de85a
into
openstack-k8s-operators:main
7 checks passed
ASBishop
pushed a commit
to ASBishop/cinder-operator
that referenced
this pull request
Mar 11, 2024
…y-operator Telemetry operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change cinder-api from a deployment to a statefulset. Although the service doesn't require preserving stateful data, it helps with the pod naming convention so they're similar to glance-api pods, and eliminates the squirrely suffixes like "cinder-api-xzkpl"