Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SRBAC by default #318

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Jan 12, 2024

This patch enables SRBAC by default instead of requiring explicit enabling like we did in OSP17.

Only the API service will include the configuration since policies are to be checked at the endpoint in Cinder API.

Jira: OSPRH-3281

@Akrog
Copy link
Contributor Author

Akrog commented Jan 18, 2024

Holding the PR until I get confirmation that this change is sufficient.

@Akrog
Copy link
Contributor Author

Akrog commented Jan 26, 2024

/retest

This patch enables SRBAC by default instead of requiring explicit
enabling like we did in OSP17.

With this it will have the same behavior as OSP17 but without the need
of policy files that explicitly define this behavior.

Only the API service will include the configuration since policies are
to be checked at the endpoint in Cinder API.

Jira: OSPRH-3281
Copy link
Contributor

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, ASBishop

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f8ef862 into openstack-k8s-operators:main Jan 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants