Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use --debug for db purge #328

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Always use --debug for db purge #328

merged 1 commit into from
Mar 19, 2024

Conversation

gibizer
Copy link
Contributor

@gibizer gibizer commented Feb 2, 2024

No description provided.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gibizer gibizer changed the title Purge default debug Always use --debug for db purge Feb 2, 2024
ASBishop pushed a commit to ASBishop/cinder-operator that referenced this pull request Mar 11, 2024
@openshift-merge-robot
Merge pull request openstack-k8s-operators#328 from karelyatin/update…
187e504 
…_ovn

Update ovn-operator to fix nil pointer error
@Akrog
Copy link
Contributor

Akrog commented Mar 14, 2024

We already dropped the debug struct, so we should be able to drop this PR.
If I'm wrong, please feel free to re-open it.

@Akrog Akrog closed this Mar 14, 2024
@gibizer gibizer reopened this Mar 18, 2024
@gibizer gibizer force-pushed the purge-default-debug branch from 68379f1 to 5630afb Compare March 18, 2024 12:43
@gibizer
Copy link
Contributor Author

gibizer commented Mar 18, 2024 •
edited
Loading

We already dropped the debug struct, so we should be able to drop this PR. If I'm wrong, please feel free to re-open it.

I totally forgot this. After rebase I still see meaningful content in this PR. So I reopened it.

@gibizer gibizer marked this pull request as ready for review March 18, 2024 12:44
@openshift-ci openshift-ci bot requested review from abays and frenzyfriday March 18, 2024 12:44
@ASBishop
Copy link
Contributor

We already dropped the debug struct, so we should be able to drop this PR. If I'm wrong, please feel free to re-open it.

I totally forgot this. After rebase I still see meaningful content in this PR. So I reopened it.

I agree this change makes sense.

ASBishop
ASBishop approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@ASBishop ASBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ASBishop, gibizer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1d901c1 into openstack-k8s-operators:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ASBishop ASBishop ASBishop approved these changes

@abays abays Awaiting requested review from abays

@frenzyfriday frenzyfriday Awaiting requested review from frenzyfriday

Assignees

@ASBishop ASBishop

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gibizer @Akrog @ASBishop @openshift-merge-robot